Fixed issue with domains when publishing a site. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue with domains being passed in the wrong format.
Fix issue with body response not being parsed correctly.
Allows you to create an item, or update it if it already exists.
Merge field automatically.
wivern-co-uk
suggested changes
Sep 9, 2019
| @@ -204,6 +210,39 @@ public function findOrCreateItemByName(string $collectionId, array $fields) | |||
| $this->cacheSet($cacheKey, $items); | |||
| return $newItem; | |||
| } | |||
|
|
|||
| public function createOrUpdateItemByName(string $collectionId, array $fields) | |||
There was a problem hiding this comment.
Hi @jbardnz and thanks for the PR. Domains fix looks good, but createOrUpdateItemByName is a custom logic of your application. Could you please, take it out, so we can merge the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with domains being passed in the wrong format.