Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: Add unistd functions to win32 #22

Draft
wants to merge 16 commits into
base: devs/expertise/native-windows
Choose a base branch
from
Draft

windows: Add unistd functions to win32 #22

wants to merge 16 commits into from

Conversation

caiosignor
Copy link
Contributor

@caiosignor caiosignor commented Mar 30, 2020 •
edited
Loading

GOALS

This PR aims to solve #4 (Remove unistd.h dependency)

How it work

Windows UCRT contains some equals functions from unistd. So as part of solution, was include #include <io.h> and #include <process.h> in src/lib/evil/evil_unistd.h

The functions below, not found in ucrt, so, i've implemeted an wrapper that is located in evil_unistd.h

  • sleep now is evil_sleep
  • usleep now is evil_usleep
  • chown now is evil_chown
  • readlink now is evil_readlink
  • setsid now is evil_setsid

Test

To test it, you need run .\configure && .\build -k0
No build errors should happen related to these functions

@JPTIZ JPTIZ self-assigned this Mar 30, 2020
@JPTIZ JPTIZ added remove-dependency Related to dependencies that should be removed. windows-native Related to port of EFL to natively compile in Windows with clang-cl labels Mar 30, 2020
@JPTIZ JPTIZ added this to the Natively Compile in Windows milestone Mar 30, 2020
@JPTIZ JPTIZ linked an issue Mar 30, 2020 that may be closed by this pull request
Remove unistd.h dependency #4
Open
@JPTIZ JPTIZ force-pushed the devs/jptiz/build-on-windows-with-clang-cl branch from cf53b62 to 5892e25 Compare April 1, 2020 21:26
@JPTIZ JPTIZ changed the base branch from devs/jptiz/build-on-windows-with-clang-cl to devs/expertise/native-windows April 6, 2020 14:01
@caiosignor caiosignor changed the title Devs/carlos/unistd windows: unistd: Add unistd functions to win32 Apr 7, 2020
@caiosignor caiosignor closed this Apr 20, 2020
@caiosignor caiosignor reopened this Apr 20, 2020
@Coquinho Coquinho assigned caiosignor and unassigned JPTIZ Apr 20, 2020
@caiosignor caiosignor changed the title windows: unistd: Add unistd functions to win32 windows: Add unistd functions to win32 Apr 28, 2020
@walac walac assigned JPTIZ and unassigned caiosignor Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JPTIZ JPTIZ

Labels
remove-dependency Related to dependencies that should be removed. windows-native Related to port of EFL to natively compile in Windows with clang-cl
Projects
None yet
Milestone
Natively Compile in Windows
Development

Successfully merging this pull request may close these issues.

Remove unistd.h dependency
2 participants
@caiosignor @JPTIZ