Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EAK-496] AEMAaCS support: Do not render default dialog dimensions #496

Closed
smiakchilo opened this issue Nov 20, 2023 · 1 comment · Fixed by #499
Closed

[EAK-496] AEMAaCS support: Do not render default dialog dimensions #496

smiakchilo opened this issue Nov 20, 2023 · 1 comment · Fixed by #499
Labels
AEM AEM-specific competencies are involved bug Something isn't working

Comments

@smiakchilo
Copy link
Collaborator

When testing the ToolKit with AEMAsCS, it was detected that a TouchUI dialog tends to display a vertical scroll bar even if the content fisually fits into the dialog height. The scroll bar disappears if no exact dialog dimensions are set.
Solution: make dialog dimensions not renderable by default. Test backward compatibility with AEM 6.5
@smiakchilo smiakchilo added bug Something isn't working Java AEM AEM-specific competencies are involved labels Nov 20, 2023
@smiakchilo smiakchilo changed the title AEMAaCS support: Do not render default dialog dimensions by default [EAK-496] AEMAaCS support: Do not render default dialog dimensions by default Nov 20, 2023
@smiakchilo smiakchilo changed the title [EAK-496] AEMAaCS support: Do not render default dialog dimensions by default [EAK-496] AEMAaCS support: Do not render default dialog dimensions Nov 20, 2023
@smiakchilo smiakchilo linked a pull request Nov 24, 2023 that will close this issue
[EAK-496] Skipped default @Dialog dimensions #499
Merged
@smiakchilo
Copy link
Collaborator Author

Scheduled for release in v. 2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AEM AEM-specific competencies are involved bug Something isn't working
Projects
EToolbox Authoring Kit Dev Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EAK-496] Skipped default @Dialog dimensions exadel-inc/etoolbox-authoring-kit
1 participant
@smiakchilo