-Flutter & Windows & lefthook "git commit" command fails

[vojte]

I have a very specific issue. I am working on a Flutter project which uses lefthook. So there is no /npm folder for example.

And this project currently doesn't work with the newest version of lefthook. It's working with version 1.2.6.

Therefore I've installed this specific lefthook version 1.2.6. When I run lefthook commands from lefthook.yml individually, everything looks fine, command line uses version 1.2.6.

The main issue is when I run "git commit" command. Then for some reason it runs few npm exec commands and uses version 1.4.3. instead. Then my git commit fails. I had to uninstall lefthook on this project as a workaround to be able to at least commit.

Do you have any idea how could I solve it and force to use lefthook version 1.2.6. within "git commit"?

I am using Windows, even tried to add lefthook path to my PATH variable but maybe in a wrong way.

This is output of my git commit command

git commit -m "[GR-3370] Better formatting, removed unused import"
Lefthook v1.4.3
RUNNING HOOK: pre-commit

  EXECUTE > pretty
Formatted 2 files (0 changed) in 0.20 seconds.

exit status 0xc0000005
SUMMARY: (done in 5.36 seconds)

And this is lefthook.yml

pre-commit:
  commands:
    pretty:
      glob: "*.dart"
      run: fvm flutter format {staged_files} && git add {staged_files}

lint:
  parallel: true
  commands:
    lint_code:
      glob: "*.dart"
      run: dart fix --apply lib && git add .

pre-push:
  commands:
    #    tests:
    #      run: flutter test
    #    exclude: "*.g.dart"
    linter:
      run: fvm flutter analyze

Thanks for any advice.

[mrexox]

Hey! You see different version probably because you have different global lefthook and lefthook from npm package. Could you please clarify a few things?

1. What is your global lefthook version? Where does it belong - which lefthook or whereis lefthook
2. What version is in your package.json?
3. What is the error you get when you just git commit? Lefthook is supposed to be backward compatible 🤔, so it's surprising for me and I'd like to fix that.

[vojte]

Sadly didn't help :(

The same as before exit status 0xc000005

Output of the command (this is OS related I guess)

LEFTHOOK_VERBOSE=true git commit
LEFTHOOK_VERBOSE=true : The term 'LEFTHOOK_VERBOSE=true' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ LEFTHOOK_VERBOSE=true git commit
+ ~~~~~~~~~~~~~~~~~~~~~

[mrexox]

Oh, I forgot that you are on Windows. Maybe this will work?

set LEFTHOOK_VERBOSE=true
git commit

[vojte]

Sorry for silence, I was a bit busier.. Unfortunately still not working.
I had to do this to enable verbose on Windows Powershell:
$env:LEFTHOOK_VERBOSE="true"

And then output was like this:

Lefthook v1.4.5
RUNNING HOOK: pre-commit
[lefthook] cmd: [git status --short]
[lefthook] err: <nil>
[lefthook] out: M  lib/constants/dimens.dart

[lefthook] cmd: [git diff --name-only --cached --diff-filter=ACMR]
[lefthook] err: <nil>
[lefthook] out: lib/constants/dimens.dart

[lefthook] files before filters:
[lib/constants/dimens.dart]
[lefthook] files after filters:
[lib/constants/dimens.dart]
[lefthook] files after escaping:
[lib/constants/dimens.dart]
[lefthook] executing: fvm flutter format lib/constants/dimens.dart && git add lib/constants/dimens.dart

  EXECUTE > pretty
Formatted 1 file (0 changed) in 0.10 seconds.

exit status 0xc0000005[lefthook] cmd: [git stash list]
[lefthook] err: <nil>
[lefthook] out:

SUMMARY: (done in 4.53 seconds)
🥊  pretty```

[mrexox]

Ok, interesting. Why does fvm flutter format returns exit status 0xc0000005? Does flutter format require some interactions in CLI? Or maybe it requires some executables to be available in the PATH variable? I'd try to figure it out. You could also try putting just this code in your .git/hooks/pre-commit just to see how it works without lefthook:

#!/bin/sh

fvm flutter format lib/constants/dimens.dart && git add lib/constants/dimens.dart

[vojte]

Thank you for looking into it, appreciate it!
I've run commit with those commands inside but got some strange error - as I am new in Flutter I am not sure what that is. I've run it again with verbose flag, putting everything here.

fvm flutter format lib/constants/dimens.dart && git add lib/constants/dimens.dart
.git/hooks/pre-commit: line 3: 1669 Segmentation fault fvm flutter format lib/constants/dimens.dart

git commit
[  +61 ms] executing: [C:\Users\Vojte\fvm\versions\3.3.10/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +65 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 135454af32477f815a7525073027a3ff9eff1bfd
[        ] executing: [C:\Users\Vojte\fvm\versions\3.3.10/] git tag --points-at 135454af32477f815a7525073027a3ff9eff1bfd
[  +57 ms] Exit code 0 from: git tag --points-at 135454af32477f815a7525073027a3ff9eff1bfd
[        ] 3.3.10
[  +42 ms] executing: [C:\Users\Vojte\fvm\versions\3.3.10/] git rev-parse --abbrev-ref --symbolic @{upstream}
[  +38 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{upstream}
[        ] origin/stable
[        ] executing: [C:\Users\Vojte\fvm\versions\3.3.10/] git ls-remote --get-url origin
[  +34 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +66 ms] executing: [C:\Users\Vojte\fvm\versions\3.3.10/] git rev-parse --abbrev-ref HEAD
[  +37 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[  +84 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +47 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[  +67 ms] executing: C:\Users\Vojte\fvm\versions\3.3.10\bin\cache\dart-sdk\bin\dart.exe format -v lib/constants/dimens.dart
[ +128 ms] Can only use --verbose with --help.
[   +2 ms] Usage: dart format [options...] <files or directories...>
[        ] -h, --help                             Print this usage information.
[        ] -v, --verbose                          Show all options and flags with --help.
[        ] Output options:
[        ] -o, --output                           Set where to write formatted output.
[        ]           [json]                       Print code and selection as JSON.
[        ]           [none]                       Discard output.
[        ]           [show]                       Print code to terminal.
[        ]           [write] (default)            Overwrite formatted files on disk.
[        ]     --show                             Set which filenames to print.
[        ]           [all]                        All visited files and directories.
[        ]           [changed] (default)          Only the names of files whose formatting is changed.
[        ]           [none]                       No file names or directories.
[        ]     --summary                          Show the specified summary after formatting.
[        ]           [line] (default)             Single-line summary.
[        ]           [none]                       No summary.
[        ]           [profile]                    How long it took for format each file.
[        ]     --set-exit-if-changed              Return exit code 1 if there are any formatting changes.
[        ] Non-whitespace fixes (off by default):
[        ]     --fix                              Apply all style fixes.
[        ]     --fix-doc-comments                 Use triple slash for documentation comments.
[        ]     --fix-function-typedefs            Use new syntax for function type typedefs.
[        ]     --fix-named-default-separator      Use "=" as the separator before named parameter default values.
[        ]     --fix-optional-const               Remove "const" keyword inside constant context.
[        ]     --fix-optional-new                 Remove "new" keyword.
[        ]     --fix-single-cascade-statements    Remove unnecessary single cascades from expression statements.
[        ] Other options:
[        ] -l, --line-length                      Wrap lines longer than this.
[        ]                                        (defaults to "80")
[        ] -i, --indent                           Add this many spaces of leading indentation.
[        ]                                        (defaults to "0")
[        ]     --follow-links                     Follow links to files and directories.
[        ]                                        If unset, links will be ignored.
[        ]     --version                          Show dart_style version.
[        ] Options when formatting from stdin:
[        ]     --selection                        Track selection (given as "start:length") through formatting.
[        ]     --stdin-name                       Use this path in error messages when input is read from stdin.
[        ]                                        (defaults to "stdin")
[        ] Run "dart help" to see global options.
[ +182 ms] "flutter format" took 462ms.
[   +4 ms] Formatting failed: 64
[        ]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      FormatCommand.runCommand (package:flutter_tools/src/commands/format.dart:60:7)
           <asynchronous suspension>
           #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1209:27)
           <asynchronous suspension>
           #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #4      CommandRunner.runCommand (package:args/command_runner.dart:209:13)
           <asynchronous suspension>
           #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
           <asynchronous suspension>
           #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
           <asynchronous suspension>
           #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
           <asynchronous suspension>
           #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #10     main (package:flutter_tools/executable.dart:91:3)
           <asynchronous suspension>


[  +75 ms] ensureAnalyticsSent: 74ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[   +1 ms] exiting with code 64
.git/hooks/pre-commit: line 3:  1248 Segmentation fault      fvm flutter format -v lib/constants/dimens.dart