Skip command unless, modified files match glob pattern

[JoyceBabu]

We are running static analysis on the code, in pre-push hook. This takes a few minutes to complete.

I want to skip running static analysis on PHP files, unless the modified files contains files matching the pattern {*.php,composer.lock,phpstan.neon}.

Is it possible to skip running a command, unless the modified files list matches a glob pattern? I tried setting the glob setting to the above pattern, but it did not skip the command.

[mrexox]

Hey! Thank you for the issue! Could you provide your lefthook.yml?

The skipping happend when you provide {files}, {push_files}, {staged_files}, or {all_files} in run option. Otherwise lefthook just executes the run command.

Also if you provide a files option which is a git command to get the desired files, lefthook will skip execution if the result of this command is empty.

Anyway, you can send your lefthook.yml, and I will tell you more concrete ways to fix this. Of course, it can be a lefthook bug :)

[JoyceBabu]

Thank you for the explanation. Here is my lefthook.yml

pre-commit:
  scripts:
    pre-commit-hook:
      runner: bash

post-checkout:
  scripts:
    post-checkout-hook:
      runner: bash

pre-push:
  scripts:
    phpstan-check:
      glob: "{*.php,composer.lock,phpstan.neon}"
      runner: bash

[mrexox]

I see! Indeed, lefthook doesn't skip execution for scripts if there is a glob. I think this is a missing feature. I will prepare a fix soon.

[mrexox]

Hey! I recalled that scripts option does not have a glob suboption. It is only for commands. I guess you want to filter the files you are trying to push, and apply phpstan-check if there are matches. That's a quick fix for you case. Lefthook initially didn't support glob for scripts.

[mrexox]

I transferred this to a discussion because I don't think it is very useful to have glob and files options for scripts. All these logic can be written in scripts which gives more control over what's going on.

I think it would be more convenient to use commands if you want glob and files and use scripts if you need better control.