Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin up IPFS as part of the CLI's dev command #13

Open
avivash opened this issue Mar 21, 2024 · 6 comments
Open

Spin up IPFS as part of the CLI's dev command #13

avivash opened this issue Mar 21, 2024 · 6 comments
Assignees

Comments

@avivash
Copy link
Member

avivash commented Mar 21, 2024

Boris and I were chatting about installing/starting the IPFS daemon as part of the CLI for now, since we will be using IPFS for at least a little bit longer and it's the only thing we don't currently do for the user

@avivash avivash self-assigned this Mar 21, 2024
@bmann
Copy link

bmann commented Mar 21, 2024

Thanks @avivash -- yeah, we may as well, then it's the one path install route. In case it's useful to look at what the original CLI does --> https://github.com/fission-codes/fission/tree/main/fission-cli

@avivash
Copy link
Member Author

avivash commented Mar 21, 2024

nice, thanks!

@avivash
Copy link
Member Author

avivash commented Mar 26, 2024

I've added this now and I think I've caught most of the edge cases, but I haven't tested on Windows yet... it should still work on Windows, but the one issue that might happen on Windows is if the user already has IPFS running then they try to change the IPFS port when starting up the EveryCLI(this should still work on Mac and Linux though)

@avivash
Copy link
Member Author

avivash commented Mar 26, 2024

Okay, I've added a workaround that should handle the situation I described above in Windows. The only thing is I don't have a way to test it 😅

@bmann
Copy link

bmann commented Mar 27, 2024

Sweet, Andy! How can I test a run through on Mac?

@avivash
Copy link
Member Author

avivash commented Mar 27, 2024

Sweet, Andy! How can I test a run through on Mac?

you'll just need to update the CLI, start it up and it will spin up IPFS for you.

if you have IPFS running somewhere else already, it will stop that instance automatically because it needs to add either the IPFS port from EveryCLI's default homestar.toml or the one specified in your custom --config arg into the IPFS config before spinning it up. That was a long-winded explanation 😅, but the short answer is it should just work if you update the CLI and run the every dev <function_path> command. It should work regardless of whether you've already installed IPFS on your machine before too. I'd like to do some testing on windows if possible though, because i'm not sure if the command i wrote to kill the existing process will work on windows yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants