Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar datepicker location, sizing, and behavior when page is scrolled #1701

Closed
joshfeck opened this issue Oct 14, 2019 · 7 comments
Closed

Comments

@joshfeck
Copy link
Contributor

joshfeck commented Oct 14, 2019

There are a few UI tweaks needed for the calendar datepickers.

  1. It's possible to have both "start" and "end" date selectors open at the same time within the Ticket Editor.
    One possible fix for this issue would be to close the datepicker UI if the user clicks anywhere outside the datepicker box.

Screen Shot 2019-10-14 at 2 03 48 PM

  1. Depending on the relative position Start/End fields, relative to where the user has scrolled to, the datepicker may be mostly out of view when opened.

Screen Shot 2019-10-14 at 2 07 05 PM

and

Screen Shot 2019-10-14 at 2 11 59 PM

  1. A similar issue happens with the tooltip hints where they're located no where near the inputs:

Screen Shot 2019-10-14 at 2 09 55 PM

@garthkoyle
Copy link
Contributor

2019-10-30_14-42-54 (1)

@tn3rb
Copy link
Member

tn3rb commented Oct 31, 2019

Just a heads up that this may be an issue with the core Gutenberg datepicker component.
Some of the positioning issues with the datepicker as well as tooltips when using those within a Modal window are core issues that they seem reluctant to address, plz see: WordPress/gutenberg#8468

@tn3rb
Copy link
Member

tn3rb commented Oct 31, 2019

Overall the WP datepicker appears to be somewhat buggy imho, so we may want to consider using one or more components from a third party library that work better. This would also allow us to construct separate components that are customized for their specific use cases.

Some examples where different datepickers might work better than expecting one to work in all cases:

  • selecting individual dates for an event in the admin
  • choosing start and end dates for the Ticket Sales period (typically a longer range than the event dates)
  • selecting dates to populate ticket options in the Ticket Selector

@garthkoyle
Copy link
Contributor

I'm not sure how to help with this. Do you want my help with trying to make a decision about how to approach this?

@joshfeck
Copy link
Contributor Author

joshfeck commented Nov 5, 2019

@tn3rb There's that other project card about using the AirBNB calendar for setting ticket sale start and end dates, and wouldn't that open from within the Card UI, outside of the modal?

Then, maybe we could use the default WP datepicker component for datetimes, but instead of opening it within the modal, it only opens from the Card UI. So no datepickers/tooltips within a modal.

One further thought on setting a datetime start + end, instead of 2 calendars (one for start and one for end of the datetime) how about have a calendar input for the start, then follow with a duration field? e.g event is 3 hours long so we provide a field to set 3 hours. Of course, some events may go more than one day so we could also provide a field to set an end date, many users may not end up using that last field.

@stale stale bot added the status:stale label Apr 4, 2020
@eventespresso eventespresso deleted a comment from stale bot Apr 7, 2020
@stale stale bot removed the status:stale label Apr 7, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This issue has been automatically closed because it has been stale for a significant period of time without any activity.

@stale stale bot closed this as completed Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants