Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-memory-database behaviour inconsistencies #9

Open
sami0421 opened this issue May 12, 2021 · 2 comments
Open

In-memory-database behaviour inconsistencies #9

sami0421 opened this issue May 12, 2021 · 2 comments

Comments

@sami0421
Copy link

Hey there :),

we really enjoy working with event-engine - thank you!

We recently encountered two inconsistencies compared to the postgres database:

  1. LikeFilter does not seem to be able to filter over nested, complex properties
  2. getDocs does return an ArrayIterator instead of a Generator

Versions:

"event-engine/discolight": "^0.2",
"event-engine/php-data": "^1.0",
"event-engine/php-document-store": "^0.6.0",
"event-engine/php-engine": "^0.14",
"event-engine/php-engine-utils": "^0.1",
"event-engine/php-json-schema": "^1.0",
"event-engine/php-logger": "^0.1",
"event-engine/php-messaging": "^0.1",
"event-engine/php-persistence": "^0.7",
"event-engine/php-postgres-document-store": "^0.9.1",
"event-engine/php-schema": "^0.1",
"event-engine/prooph-v7-event-store": "^0.8",

Any help is appreciated :)!

Cheers

@julia909
Copy link

Hi!

Additionally to the inconsistencies mentioned above, we encountered another inconsistency:

The in-memory-database converts simple string-wrapper objects in a filter value into actual strings. Therefore, if you forget to cast the filter value to string in the code, the in-memory-database still finds the queried data while the postgresql database does not.

We are happy for any feedback :)
Cheers

@codeliner
Copy link
Contributor

Hi @sami0421 and @julia909 , sorry for answering late. I somehow missed the issue. Too much github notifications recently ...

Can you provide failing test cases for mentioned inconsistencies? I think we can solve the differences together ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants