Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests way too long on WIndows ! #395

Open
gmaze opened this issue Sep 25, 2024 · 7 comments
Open

CI tests way too long on WIndows ! #395

gmaze opened this issue Sep 25, 2024 · 7 comments
Labels
CI Continuous Integration tools help wanted performance

Comments

@gmaze
Copy link
Member

gmaze commented Sep 25, 2024

We need to understand why CI tests are so much longer with Windows OS than with the other Linux and Mac.

They can take longer than the runner cancelling policy of 45mins, eg:

https://github.com/euroargodev/argopy/actions/runs/11027230679/job/30627964822

which make the CI tests suite to fail for the wrong reasons

Any idea of how to improve this or to understand why this is the case ?

@gmaze gmaze added help wanted performance CI Continuous Integration tools labels Sep 25, 2024
@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2024

and yes, fail-fast is set to false on the workflow

@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2024

stupid me: timeout-minutes: 45 !

@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2024

why did we set such a time out ?

@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2024

well, that does not explain why CI tests remain much slower on Windows

@ocefpaf
Copy link
Collaborator

ocefpaf commented Sep 25, 2024

I did look at your setup but Windows have some aggressive file locking that can make some IO operations quite slow. Sometimes creating the environment is the bottleneck, and if that is the case here, I wonder if pixi could help. I can try a PR n xt week if you are interested in experimenting with it.

@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2024

thanks @ocefpaf !
let me check first if the env is the bottleneck

@gmaze
Copy link
Member Author

gmaze commented Sep 25, 2024

building/restoring the env with micromamba takes about 5mins in Windows, while is takes 1mins (build) or 15 seconds (restore from cache) under Linux and Mac OS, even if the env is in cache and about the same size (600 vs 500 mb)

as an indication, the tests suite takes about:

  • 30mins to run under Linux
  • 25mins under Mac Os
  • 50mins under Windows

so even if we install the env in about seconds, running the suite under Windows remains slower by about 15 to 20 mins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools help wanted performance
Projects
None yet
Development

No branches or pull requests

2 participants