Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrument specific ATR flight-phase separation files #32

Open
observingClouds opened this issue Dec 14, 2023 · 5 comments
Open

Add instrument specific ATR flight-phase separation files #32

observingClouds opened this issue Dec 14, 2023 · 5 comments

Comments

@observingClouds
Copy link

Hi,

Over in eurec4a/eurec4a-intake#158 the question was raised if it would be feasible to add the ATR metadata files that have been created for the isotope record to this flight-segmentation repository as they closely match its syntax.

An example file looks like

name: RF03 
mission: EUREC4A
flight_id: ATR-0126 
contacts:
- name: Author
  email: [email protected]
date: 2020-01-26 
flight_report: https://observations.ipsl.fr/aeris/eurec4a-data/REPORTS/ATR-42/2020/20200126/ATR-0126.pdf 
takeoff: 2020-01-26 11:34:57 
landing: 2020-01-26 16:08:07 
events: []
remarks: 'synchronisation problem of Picarro with ATR core data, shifting during flight'
segments:
- kind: dry event
  name: D1
  start: 2020-01-26 15:46:00
  end: 2020-01-26 16:04:00

What would be needed to make these files available through the flight-segmentation API? Should the files be copied into this repo or could they be accessed from its current published location at https://observations.ipsl.fr/aeris/eurec4a-data/AIRCRAFT/ATR/vapour/ ?

@observingClouds
Copy link
Author

@observingClouds
Copy link
Author

There are also additional files around the turbulence measurements at https://observations.ipsl.fr/aeris/eurec4a-data/AIRCRAFT/ATR/SAFIRE-TURB/PROCESSED/YAML/v1.9/

@d70-t
Copy link
Collaborator

d70-t commented Dec 15, 2023

Definitely those files should be integrated into the flight segmentation repo!

To keep the repo useful, we however have to ensure that the format is consistent between the platforms. Issues I currently see are

  • remarks should be a sequence (i.e. list), not a string
  • kind should be kinds and should be a sequence as well
  • the ATR files sometimes use segments and sometimes use legs, we should unify them to segments
  • we have one mapping (i.e. dictionary) per flight, not multiple (due to the splitting in multiple topic files, there's effectively one mapping per flight per file.
  • we probably want to have a look at the common vocabulary and check if we
    • can replace some kinds by ones from the common vocabulary
    • have to extend the common vocabulary

The multiple files per flight structure seems to encode different kinds of segments (e.g. there are legs with kind "Just above Cld base", in longlegs and longestlegs files). Likely there's a need to differentiate those when using the metadata. In the schema we've intended back when creating the flight segmentation files for HALO and P3, this was the reason why we introduced kinds as a sequence: that way, we can encode e.g. a segment as ["Just above Cld base", "longestleg"], such that users can later on filter on either or both of these.

I guess if we convert the keys and datatypes as outlined above, it should be rather simple to join all files of a flight into one and we are good to go.

Another question might be, if we have to support older code reading these files. If that would be the case, I'd suggest to create a different generated output (in addition to all_flights.yaml), which would correspond more to the current state of the ATR files, but for all aircraft (if possible).

@d70-t
Copy link
Collaborator

d70-t commented Dec 15, 2023

There's another issue. It seems like some flight ids (e.g. ATR-0126) have been assigned to multiple flights. It's understandable where this came from (the naming scheme and both flights were on the same day), but it's incompatible with the data model of this repository (there can only be one flight per flight id). Also, the whole purpose of the flight id is to uniquely identify the flight... Thus we need to find a way of making these flight ids unique.

@observingClouds
Copy link
Author

There's another issue. It seems like some flight ids (e.g. ATR-0126) have been assigned to multiple flights. It's understandable where this came from (the naming scheme and both flights were on the same day), but it's incompatible with the data model of this repository (there can only be one flight per flight id). Also, the whole purpose of the flight id is to uniquely identify the flight... Thus we need to find a way of making these flight ids unique.

For future reference: In eurec4a/eurec4a-intake#158 this issue also occurred and the flights got a continuous research flight id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants