Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FragmentationMatchScore with additional metrics #547

Open
PMSeitzer opened this issue Jun 8, 2022 · 6 comments
Open

Enhance FragmentationMatchScore with additional metrics #547

PMSeitzer opened this issue Jun 8, 2022 · 6 comments
Assignees

Comments

@PMSeitzer
Copy link
Collaborator

Including (but not limited to), modified cosine score, neutral loss match score, and the updated cosine score.

This can be used very generally, and updated in the GUI, but was originally devised as a part of #543, #546, and associated mass_spec case https://github.com/calico/mass_spec/issues/752

@PMSeitzer PMSeitzer self-assigned this Jun 8, 2022
@PMSeitzer
Copy link
Collaborator Author

Return to this after starting mass_spc case https://github.com/calico/mass_spec/issues/752

@PMSeitzer PMSeitzer added the stalled On hold label Jun 13, 2022
@PMSeitzer
Copy link
Collaborator Author

PMSeitzer commented Jun 16, 2022

@PMSeitzer PMSeitzer added this to the 2.0.1 milestone Jul 25, 2022
@PMSeitzer
Copy link
Collaborator Author

more information about various spectral scoring approaches:
https://www.biorxiv.org/content/biorxiv/early/2022/06/02/2022.06.01.494370.full.pdf

@PMSeitzer
Copy link
Collaborator Author

PMSeitzer commented Aug 8, 2022

Modified cosine score, as it is explained in the original manuscript (https://www.pnas.org/doi/abs/10.1073/pnas.1203689109):

Vector similarities are calculated for every possible pair of spectra with a
minimum of six matching fragment ions (i.e., peaks) with similarity
determined by using a modified cosine calculation that takes into
account the relative intensities of the fragment ions as well as the
precursor m/z difference between the paired spectra

This has come to mean something more specific:

Two peaks are considered a potential match if their m/z ratios lie within the given ‘tolerance’, or if their m/z ratios lie within the tolerance once a mass-shift is applied. The mass shift is simply the difference in precursor-m/z between the two spectra.

So, a peak may match another peak after a mass-shift is applied.

See this implementation:
https://github.com/matchms/matchms/blob/master/matchms/similarity/ModifiedCosine.py#L109-L129

It looks like they are matching to both the m/z and NL m/z of an observed spectrum (where NL m/z = precursorMz - fragMz).

@PMSeitzer PMSeitzer modified the milestones: 2.0.1, 2.0.2 Aug 24, 2022
@PMSeitzer PMSeitzer modified the milestones: 2.0.2, 2.0.3, 2.0.4 Oct 8, 2022
@PMSeitzer PMSeitzer added this to the 2.10.17 milestone Jun 10, 2024
@PMSeitzer
Copy link
Collaborator Author

Inspired by ASMS 2024, re-opening this case. Introduced now in modified cosine score, flash entropy, kullback-leibler divergence, Jansen-Shanon divergence, etc.

@PMSeitzer PMSeitzer removed the stalled On hold label Jun 10, 2024
@PMSeitzer PMSeitzer modified the milestones: 2.10.17, 2.10.18 Jun 17, 2024
@PMSeitzer
Copy link
Collaborator Author

spectral entropy python:
https://github.com/YuanyueLi/SpectralEntropy

@PMSeitzer PMSeitzer removed this from the 2.10.18 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant