Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site renders not correct if RSS Subscribe Button is activated / path is given in config.toml #30

Open
ghost opened this issue Aug 23, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 23, 2019

As discribed in #29 The Site doesn't render as expected if RSS Subscribe Button is Inserted in header.html

Using the following Code:

      <div class="site-nav-right">
        <div class="social-links">
                    {{ if .Site.Params.githubName }}<a class="social-link" href="https://github.com/{{ .Site.Params.githubName }}" target="_blank" rel="noopener"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M12 .297c-6.63 0-12 5.373-12 12 0 5.303 3.438 9.8 8.205 11.385.6.113.82-.258.82-.577 0-.285-.01-1.04-.015-2.04-3.338.724-4.042-1.61-4.042-1.61C4.422 18.07 3.633 17.7 3.633 17.7c-1.087-.744.084-.729.084-.729 1.205.084 1.838 1.236 1.838 1.236 1.07 1.835 2.809 1.305 3.495.998.108-.776.417-1.305.76-1.605-2.665-.3-5.466-1.332-5.466-5.93 0-1.31.465-2.38 1.235-3.22-.135-.303-.54-1.523.105-3.176 0 0 1.005-.322 3.3 1.23.96-.267 1.98-.399 3-.405 1.02.006 2.04.138 3 .405 2.28-1.552 3.285-1.23 3.285-1.23.645 1.653.24 2.873.12 3.176.765.84 1.23 1.91 1.23 3.22 0 4.61-2.805 5.625-5.475 5.92.42.36.81 1.096.81 2.22 0 1.606-.015 2.896-.015 3.286 0 .315.21.69.825.57C20.565 22.092 24 17.592 24 12.297c0-6.627-5.373-12-12-12"/></svg></a>{{end}}

                    {{ range .AlternativeOutputFormats -}}
                           {{ printf `<link rel="%s" type="%s" href="%s" title="%s" />` .Rel .MediaType.Type .Permalink $.Site.Title | safeHTML }}
                    {{ end -}}

        </div>  
        {{ if .Site.Params.RSSLink}}
        <a class="subscribe-button" href="{{.Site.Params.RSSLink }}">Subscribe</a> </div>
        {{else if .Site.Params.showSubscribe}}
        <a class="subscribe-button" href="{{if .IsNode}}{{.RSSLink}}{{else}}{{"rss/index.xml" | absURL}}{{end}}">Subscribe</a>
        {{end}}    
      </div>

The Problematic Code seems to be:

        {{ if .Site.Params.RSSLink}}
        <a class="subscribe-button" href="{{.Site.Params.RSSLink }}">Subscribe</a> </div>
        {{else if .Site.Params.showSubscribe}}
        <a class="subscribe-button" href="{{if .IsNode}}{{.RSSLink}}{{else}}{{"rss/index.xml" | absURL}}{{end}}">Subscribe</a>
        {{end}}   

How do I get my RSS Subscribe Button to work?

@ghost
Copy link
Author

ghost commented Dec 2, 2019

I just retried using this theme, now I want to narrow down my question:
How am I supposed to enter the RSS Link?

I tried:
RSSLink = "/rss/index.xml"
RSSLink = "/index.xml"
RSSLink = "/rss"

Either the subscibe Button did't work and pointed to 404 or index.html or the Gap appears, So I really don't know how I sould implement RSS, this time I didn't touch the foot.html and worked just at the config.toml, with said results. It also seems, the only way for me to get rid of the Gap is to completly disable RSS.
Any help is highly appreciated, since this is a very beautiful theme!

cheers - chrissly90

@ghost ghost changed the title Site renders not correct if RSS Subscribe Button is inserted if Header Site renders not correct if RSS Subscribe Button is activated / URL is given in config.toml Dec 2, 2019
@ghost ghost changed the title Site renders not correct if RSS Subscribe Button is activated / URL is given in config.toml Site renders not correct if RSS Subscribe Button is activated / path is given in config.toml Dec 2, 2019
@albanleandri
Copy link

write post/index.xml

@ghost
Copy link
Author

ghost commented Dec 26, 2019

I'll try, and report back later, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant