Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct Pandas Datatypes for columns #47

Open
olejandro opened this issue Mar 8, 2023 · 3 comments
Open

Use correct Pandas Datatypes for columns #47

olejandro opened this issue Mar 8, 2023 · 3 comments

Comments

@olejandro
Copy link
Member

Currently rows containing na values are not dropped before generating output (i.e. csv files). However, some of the outputs (the ones not filtered by attribute) are based on larger tables (e.g FI_Comm) from which all rows and only some columns are used for a particular csv. This results in a large number of additional rows generated by the tool. Could we add a switch that would control whether the rows containing na values are dropped? At this stage, it is probably best to drop the rows by default.

@olejandro
Copy link
Member Author

@siddharth-krishna
Copy link
Collaborator

#63 was a temporary hack to filter out rows with None string values. Let's keep this issue open to track progress on using the correct dtypes for columns so that we can just use pd.dropna. This will also help us avoid having to explicitly convert the Years column to ints, etc.

@olejandro
Copy link
Member Author

#66 applies the hack to all the columns.

@siddharth-krishna siddharth-krishna changed the title Rows with na values should be removed for some output tables Use correct Pandas Datatypes for columns Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants