Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE option from syssettings not overwritten by scenario file #269

Open
olejandro opened this issue Dec 30, 2024 · 1 comment
Open

IE option from syssettings not overwritten by scenario file #269

olejandro opened this issue Dec 30, 2024 · 1 comment

Comments

@olejandro
Copy link
Member

olejandro commented Dec 30, 2024

@olejandro A small follow-up: I was still curious about whether it indeed works as you described, and therefore I now decided to give it a test on my Windows 11 computer. I downloaded the current Master branch version, and extracted it to a local folder. I first tested running xl2times with the original Demo4 model, with the files listed in the command line (and with the regular scenario Scen_Peak_RSV.xlsx at the end). The run seemed to work well, although with some unexpected warnings such as the following:

  • WARNING : datatypes.Tag has an unknown Tag Tag.comagg not in veda-tags.json
  • WARNING : Cannot produce table TM_DEFVAL because Attributes does not contain the required columns - tm_defval

Anyway, then I tested with adding a default IE option for COM_PKRSV into SysSettings, and an explicit overriding option for it into Scen_Peak_RSV.xlsx. However, the output only contained the wrong value (the default). The correct option defined in Scen_Peak_RSV.xlsx thus did not make it to the DD file (it was shown in the raw tables, though). I then tested by removing the default option from SysSettings, and only then I got the correct option written out.

Hence, my conclusion from this test is that currently the handling of the IE defaults does not seem to work in the correct way, unless I am doing something wrong? In addition, I would really suggest to implement a list file option, such that one can specify the scenario order there (with scenario names such as base, peak_rsv, and not file names), because listing all the files (apparently now required also with their subfolder paths) in the command line can get quite cumbersome for users, unless I am missing something.

Originally posted by @Antti-L in #260 (comment)

@olejandro
Copy link
Member Author

@siddharth-krishna we should probably use this issue as an oportunity for adding a test on this?

If we do it via regression testing, is there a common way of creating an overview of issues that are tested for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant