From fcd11cdf383aa84c313ac046b54ad085c433fe50 Mon Sep 17 00:00:00 2001
From: Sam West <sam.west@csiro.au>
Date: Thu, 22 Feb 2024 09:18:52 +1100
Subject: [PATCH] remove shell=True in dd_to_csv run on non-windows OSes

---
 tests/test_transforms.py | 5 -----
 utils/run_benchmarks.py  | 3 ++-
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/tests/test_transforms.py b/tests/test_transforms.py
index 679cf30..2810f1b 100644
--- a/tests/test_transforms.py
+++ b/tests/test_transforms.py
@@ -88,11 +88,6 @@ def test_uc_wildcards(self):
             dictionary = pickle.load(f)
         df = df_in.copy()
 
-        # df_in = pd.read_parquet("tests/data/process_uc_wildcards_austimes_data.parquet")
-        # with open("tests/data/process_uc_wildcards_austimes_dict.pkl", "rb") as f:
-        #     dictionary = pickle.load(f)
-        # df = df_in.query("region in ['ACT', 'NSW']")
-
         t0 = datetime.now()
 
         # optimised functions
diff --git a/utils/run_benchmarks.py b/utils/run_benchmarks.py
index 0eeb889..6548bf1 100644
--- a/utils/run_benchmarks.py
+++ b/utils/run_benchmarks.py
@@ -1,4 +1,5 @@
 import argparse
+import os
 import re
 import shutil
 import subprocess
@@ -159,7 +160,7 @@ def run_benchmark(
                 stdout=subprocess.PIPE,
                 stderr=subprocess.STDOUT,
                 text=True,
-                shell=True,
+                shell=True if os.name == "nt" else False,
             )
             if res.returncode != 0:
                 # Remove partial outputs