Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fides.js API options and improve automated tests #4314

Merged
merged 24 commits into from
Oct 23, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Oct 22, 2023

Closes PROD-1234

Description Of Changes

This is a few small changes to the FidesJS API for some different names of options/events, and some fixes and improvements to the Cypress tests.

Code Changes

  • Rename FidesPreferenceToggled -> FidesUIChanged
  • Rename window.config.fides -> window.config.tc_info
  • Update Cypress specs

Deferred to follow-up issue:

  • Make window.config.tc_info a configurable option, change default to window.fides_config

Steps to Confirm

n/a

Pre-Merge Checklist

Copy link
Contributor Author

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and a few suggestions for myself!

clients/fides-js/src/fides-tcf.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/initialize.ts Show resolved Hide resolved
clients/fides-js/src/lib/initialize.ts Show resolved Hide resolved
clients/privacy-center/pages/api/fides-js.ts Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Oct 22, 2023

Passing run #4739 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 846ed0b into c4b21dd...
Project: fides Commit: 5def1ceb61 ℹ️
Status: Passed Duration: 00:51 💡
Started: Oct 23, 2023 1:09 PM Ended: Oct 23, 2023 1:10 PM

Review all test suite changes for PR #4314 ↗︎

@NevilleS NevilleS marked this pull request as ready for review October 22, 2023 18:40
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up these cypress tests! The code comments make them much easier to understand 🌟

CHANGELOG.md Outdated Show resolved Hide resolved
clients/fides-js/src/fides-tcf.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/initialize.ts Show resolved Hide resolved
@NevilleS
Copy link
Contributor Author

@eastandwestwind updated 👍

@NevilleS NevilleS merged commit 56726fc into main Oct 23, 2023
10 checks passed
@NevilleS NevilleS deleted the PROD-1234-ns-update-fides-js-api branch October 23, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants