From 8d7f2fd77f987b515770865fb3c7317ced6b1111 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 8 Apr 2022 11:25:02 -0500 Subject: [PATCH] Change the version exception to a warning (#477) * Change the version exception to a warning * remove the failing test Co-authored-by: ThomasLaPiana --- fidesctl/src/fidesctl/cli/utils.py | 1 - fidesctl/tests/cli/test_cli_utils.py | 10 ---------- 2 files changed, 11 deletions(-) diff --git a/fidesctl/src/fidesctl/cli/utils.py b/fidesctl/src/fidesctl/cli/utils.py index 2dd97601ef..85a71ef187 100644 --- a/fidesctl/src/fidesctl/cli/utils.py +++ b/fidesctl/src/fidesctl/cli/utils.py @@ -35,7 +35,6 @@ def check_server(cli_version: str, server_url: str) -> None: echo_red( f"Mismatched versions!\nServer Version: {server_version}\nCLI Version: {cli_version}" ) - raise SystemExit(1) def pretty_echo(dict_object: Dict, color: str = "white") -> None: diff --git a/fidesctl/tests/cli/test_cli_utils.py b/fidesctl/tests/cli/test_cli_utils.py index 361e785a42..267b6fae3b 100644 --- a/fidesctl/tests/cli/test_cli_utils.py +++ b/fidesctl/tests/cli/test_cli_utils.py @@ -1,6 +1,3 @@ -import importlib -from unittest.mock import patch - import pytest import fidesctl.cli.utils as utils @@ -11,10 +8,3 @@ def test_check_server_bad_ping(): "Check for an exception if the server isn't up." with pytest.raises(SystemExit): utils.check_server("foo", "http://fake_address:8080") - - -@pytest.mark.integration -def test_check_server_version_mismatch(test_config): - "Check for a warning message if there is a version mismatch." - with pytest.raises(SystemExit): - utils.check_server("0.0.1", test_config.cli.server_url)