From 77bc38168afeb943440a0857be972c8c19701cc3 Mon Sep 17 00:00:00 2001
From: jpople <jeremy@ethyca.com>
Date: Fri, 8 Sep 2023 16:10:18 -0400
Subject: [PATCH] re-enable custom fields for new data use form (#4050)

---
 .../PrivacyDeclarationForm.tsx                | 62 ++++++++++++++++---
 .../PrivacyDeclarationFormTab.tsx             |  8 +--
 2 files changed, 58 insertions(+), 12 deletions(-)

diff --git a/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationForm.tsx b/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationForm.tsx
index 7209c97c4b..12350936fd 100644
--- a/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationForm.tsx
+++ b/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationForm.tsx
@@ -7,6 +7,11 @@ import { Form, Formik, FormikHelpers } from "formik";
 import { useMemo } from "react";
 import * as Yup from "yup";
 
+import {
+  CustomFieldsList,
+  CustomFieldValues,
+  useCustomFields,
+} from "~/features/common/custom-fields";
 import {
   CustomCreatableSelect,
   CustomSelect,
@@ -14,6 +19,7 @@ import {
   CustomTextInput,
 } from "~/features/common/form/inputs";
 import { FormGuard } from "~/features/common/hooks/useIsAnyFormDirty";
+import SystemFormInputGroup from "~/features/system/SystemFormInputGroup";
 import {
   DataCategory,
   Dataset,
@@ -21,12 +27,11 @@ import {
   DataUse,
   LegalBasisForProcessingEnum,
   PrivacyDeclarationResponse,
+  ResourceTypes,
   SpecialCategoryLegalBasisEnum,
 } from "~/types/api";
 import { Cookies } from "~/types/api/models/Cookies";
 
-import SystemFormInputGroup from "../SystemFormInputGroup";
-
 export const ValidationSchema = Yup.object().shape({
   data_categories: Yup.array(Yup.string())
     .min(1, "Must assign at least one data category")
@@ -35,6 +40,7 @@ export const ValidationSchema = Yup.object().shape({
 });
 
 export type FormValues = Omit<PrivacyDeclarationResponse, "cookies"> & {
+  customFieldValues: CustomFieldValues;
   cookies?: string[];
 };
 
@@ -54,6 +60,7 @@ const defaultInitialValues: FormValues = {
   data_shared_with_third_parties: false,
   third_parties: "",
   shared_categories: [],
+  customFieldValues: {},
   cookies: [],
   id: "",
 };
@@ -87,6 +94,7 @@ export interface DataProps {
   allDataUses: DataUse[];
   allDataSubjects: DataSubject[];
   allDatasets?: Dataset[];
+  includeCustomFields?: boolean;
   cookies?: Cookies[];
 }
 
@@ -97,6 +105,7 @@ export const PrivacyDeclarationFormComponents = ({
   allDatasets,
   cookies,
   values,
+  includeCustomFields,
   privacyDeclarationId,
 }: DataProps & {
   values: FormValues;
@@ -320,12 +329,19 @@ export const PrivacyDeclarationFormComponents = ({
           variant="stacked"
         />
       </SystemFormInputGroup>
+      {includeCustomFields ? (
+        <CustomFieldsList
+          resourceType={ResourceTypes.PRIVACY_DECLARATION}
+          resourceFidesKey={privacyDeclarationId}
+        />
+      ) : null}
     </Stack>
   );
 };
 
 export const transformPrivacyDeclarationToFormValues = (
-  privacyDeclaration?: PrivacyDeclarationResponse
+  privacyDeclaration?: PrivacyDeclarationResponse,
+  customFieldValues?: CustomFieldValues
 ): FormValues => {
   if (privacyDeclaration) {
     const formCookies =
@@ -334,6 +350,7 @@ export const transformPrivacyDeclarationToFormValues = (
         : undefined;
     return {
       ...privacyDeclaration,
+      customFieldValues: customFieldValues || {},
       cookies: formCookies,
     };
   }
@@ -347,17 +364,46 @@ export const transformPrivacyDeclarationToFormValues = (
 export const usePrivacyDeclarationForm = ({
   onSubmit,
   initialValues: passedInInitialValues,
+  privacyDeclarationId,
 }: Omit<Props, "onDelete"> & Pick<DataProps, "allDataUses">) => {
+  const { customFieldValues, upsertCustomFields } = useCustomFields({
+    resourceType: ResourceTypes.PRIVACY_DECLARATION,
+    resourceFidesKey: privacyDeclarationId,
+  });
+
   const initialValues = useMemo(
-    () => transformPrivacyDeclarationToFormValues(passedInInitialValues),
-    [passedInInitialValues]
+    () =>
+      transformPrivacyDeclarationToFormValues(
+        passedInInitialValues,
+        customFieldValues
+      ),
+    [passedInInitialValues, customFieldValues]
   );
 
-  const handleSubmit = (
+  const handleSubmit = async (
     values: FormValues,
     formikHelpers: FormikHelpers<FormValues>
   ) => {
-    onSubmit(transformFormValueToDeclaration(values), formikHelpers);
+    const { customFieldValues: formCustomFieldValues } = values;
+    const declarationToSubmit = transformFormValueToDeclaration(values);
+
+    const success = await onSubmit(declarationToSubmit, formikHelpers);
+    if (success) {
+      // find the matching resource based on data use and name
+      const customFieldResource = success.filter(
+        (pd) =>
+          pd.data_use === values.data_use &&
+          // name can be undefined, so avoid comparing undefined == ""
+          // (which we want to be true) - they both mean the PD has no name
+          (pd.name ? pd.name === values.name : true)
+      );
+      if (customFieldResource.length > 0) {
+        await upsertCustomFields({
+          customFieldValues: formCustomFieldValues,
+          fides_key: customFieldResource[0].id,
+        });
+      }
+    }
   };
 
   return { handleSubmit, initialValues };
@@ -367,7 +413,7 @@ interface Props {
   onSubmit: (
     values: PrivacyDeclarationResponse,
     formikHelpers: FormikHelpers<FormValues>
-  ) => void;
+  ) => Promise<PrivacyDeclarationResponse[] | undefined>;
   onCancel: () => void;
   initialValues?: PrivacyDeclarationResponse;
   privacyDeclarationId?: string;
diff --git a/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationFormTab.tsx b/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationFormTab.tsx
index 3125c3d17a..cb870564ca 100644
--- a/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationFormTab.tsx
+++ b/clients/admin-ui/src/features/system/system-form-declaration-tab/PrivacyDeclarationFormTab.tsx
@@ -233,13 +233,12 @@ const PrivacyDeclarationFormTab = ({
     handleCloseDictModal();
   };
 
-  const handleSubmit = (values: PrivacyDeclarationResponse) => {
+  const handleSubmit = async (values: PrivacyDeclarationResponse) => {
     handleCloseForm();
     if (currentDeclaration) {
-      handleEditDeclaration(currentDeclaration, values);
-    } else {
-      handleCreateDeclaration(values);
+      return handleEditDeclaration(currentDeclaration, values);
     }
+    return handleCreateDeclaration(values);
   };
 
   const handleDelete = async (
@@ -300,6 +299,7 @@ const PrivacyDeclarationFormTab = ({
           initialValues={currentDeclaration}
           onSubmit={handleSubmit}
           onCancel={handleCloseForm}
+          includeCustomFields={includeCustomFields}
           {...dataProps}
         />
       </PrivacyDeclarationFormModal>