make ValidateTransactionWithState also consider sgt balance #12
Conversation
| if opts.L1CostFn != nil { | ||
| if l1Cost := opts.L1CostFn(tx.RollupCostData()); l1Cost != nil { // add rollup cost | ||
| cost = cost.Add(cost, l1Cost) | ||
| } | ||
| } | ||
| if balance.Cmp(cost) < 0 { | ||
| return fmt.Errorf("%w: balance %v, tx cost %v, overshot %v", core.ErrInsufficientFunds, balance, cost, new(big.Int).Sub(cost, balance)) | ||
| if balance.Cmp(cost) < 0 && sgtBalance.Cmp(cost) < 0 { |
There was a problem hiding this comment.
The validation logic is not consistent with execution logic where msg.from is 0x0 (
op-geth/core/state_transition.go
Line 342 in 25669f6
There was a problem hiding this comment.
Good catch, it seems the check for zero account is no longer necessary after we avoided evm.call, so removed.
The UseSoulGasToken flag is added back.
Does this mean that if the sender’s native gas token balance is zero or insufficient to cover the gas fee, the transaction will always fail, regardless of the soul gas token balance? |
It will only fail when both native balance and sgt balance are not sufficient. |
what I ask is the condition before this PR |
Before this change, it only checks native balance, so yes. |
This PR fixes #11