-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports batch acquisition of hashes #11
Open
iteyelmp
wants to merge
10
commits into
master
Choose a base branch
from
hashes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+107
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Aug 28, 2024
As we discussed offline, if this PR doesn’t improve performance in Vitalik’s case, we may need to involve more people for further discussion. |
syntrust
reviewed
Sep 5, 2024
qzhodl
reviewed
Sep 24, 2024
syntrust
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement this issue , Provides batch acquisition of data chunk hashes to reduce the number of network requests.
For small files like those on Vitalik's blog, the optimization doesn't significantly change the time taken. However, for larger files, the optimization provides a noticeable improvement.
larger file size: 3.9 MB
Old: Time taken for
getChunkHash
: 0.464 minutesNew: Time taken for
getChunkHashes
: 0.172 minutesAdditionally, we can encapsulate the parameters required before uploading a file into a single function, retrieving them all at once to reduce network requests.
function getUploadInfo(bytes memory name) public override view returns (StorageMode mode, uint256 count, uint256 payment)