Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fee history #86

Merged
merged 3 commits into from
Sep 11, 2023
Merged

feat: fee history #86

merged 3 commits into from
Sep 11, 2023

Conversation

0xSulpiride
Copy link
Member

Description

  • feat: skandha_feeHistory
  • fix: check for execution revert before submitting a bundle

feeHistory:
image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@0xSulpiride 0xSulpiride marked this pull request as ready for review September 6, 2023 15:03
ch4r10t33r
ch4r10t33r reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do you have any idea why are the tests failing?

@0xSulpiride
Copy link
Member Author

0xSulpiride commented Sep 11, 2023 •
edited
Loading

@ch4r10t33r new tests were failing. I addressed them in the recent PR that just got merged. Tests should be fine now.

ch4r10t33r
ch4r10t33r approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@taylorferran Pls document the new endpoints.

@0xSulpiride 0xSulpiride merged commit b96cc1f into master Sep 11, 2023
@0xSulpiride 0xSulpiride deleted the fee-history branch September 11, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@arddluma arddluma Awaiting requested review from arddluma

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSulpiride @ch4r10t33r