Investigate contract inefficiencies #3540
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ``web3.ens`` invokes the ``@property`` getter on ``ens``. This getter sets ``self._ens`` on the ``web3`` object if it is empty. We do not need to do invoke this getter until ``ens`` is actually called. Instead, use the pointer to ``self._ens`` directly to avoid overhead when the majority of uses may not even be using ENS.
- When initializing a contract, we create the ``ContractFunction`` objects for each function and assign them to the ``contract.functions`` attribute. Then we instantiate the ``contract.caller`` and inside the ``ContractCaller`` init, we re-instantiate each contract function. Pass these around instead which will prevent so many calls for validation. They are already built, so there is no reason to build them again.
fselmo
force-pushed
the
investigate-contract-inefficiencies
branch
2 times, most recently
from
d716d52
to
926a200
Compare
fselmo
force-pushed
the
investigate-contract-inefficiencies
branch
from
926a200
to
bf62ecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
w3.ens), set all initializing vars tow3._enswhich is the reference thatw3.enslooks for. This leaves the check for an emptyw3._ensfollowed by subsequent instantiation for whenw3.ensis called directly by the user, not for any internal setup.Contractinit, as well as for theContractCaller. The caller is instantiated in theContractinit when we setself.caller = ContractCaller(...). Pass along the already builtContractFunctionsto theContractCallerso that it doesn't have to re-build them.How was it fixed?
w3._ensrather thanw3.ens(which initializes an ENS instance if it is empty).contract_functions: ContractFunctionsto theContractCallerclass so that we can pass the functions around instead of rebuilding them everywhere they are needed.Todo:
Cute Animal Picture
0_o