Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec tests for "ssz generic" #16

Open
ralexstokes opened this issue Aug 29, 2019 · 1 comment
Open

Add spec tests for "ssz generic" #16

ralexstokes opened this issue Aug 29, 2019 · 1 comment

Comments

@ralexstokes
Copy link
Member

What is wrong?

There are two types of spec tests we aren't running: "ssz static" and "ssz generic".

I don't expect any surprises because afaik these tests are generated w/ py-ssz which we directly use. We should add them to our fixture testing though just for completeness.

How can it be fixed

Add the tests. Add the test type and test handler to parse/run the test data.

@ralexstokes
Copy link
Member Author

the "static" tests are in ethereum/trinity#998.

@ralexstokes ralexstokes changed the title Add spec tests for "ssz static" and "ssz generic" Add spec tests for "ssz generic" Sep 4, 2019
@ralexstokes ralexstokes transferred this issue from ethereum/trinity Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant