Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Confirm password" flow for validator client key store #15

Open
ralexstokes opened this issue Mar 25, 2020 · 0 comments
Open

"Confirm password" flow for validator client key store #15

ralexstokes opened this issue Mar 25, 2020 · 0 comments

Comments

@ralexstokes
Copy link
Member

What is wrong?

Right now, we can import a key to the key store for the validator client and encrypt it on disk using eth_keyfile.

We only ask the user for the password to this file once, with no confirmation. Obviously bad for typo failure modes.

How can it be fixed

Confirm the password and make sure they match before accepting the imported key.
@ralexstokes ralexstokes transferred this issue from ethereum/trinity Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ralexstokes