Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests exercising LMD GHOST fork choice #11

Open
ralexstokes opened this issue Jul 13, 2020 · 2 comments
Open

Enable tests exercising LMD GHOST fork choice #11

ralexstokes opened this issue Jul 13, 2020 · 2 comments

Comments

@ralexstokes
Copy link
Member

Tests added in ethereum/trinity#1833 are currently disabled as they timeout in CI.

The tests run locally and while they are markedly slower, they don't seem to be taking as long as CI reports (exceeding the 10min context deadline...).

These tests are high-level and arguably are "integration tests" -- Does something change if we run the tests in their own CI run? (an eth2-integration test run???)

Otherwise, we should implement performance enhancements to the state transition and re-enable them.

@ralexstokes
Copy link
Member Author

For what it is worth, the tests do run and pass locally...

@ralexstokes
Copy link
Member Author

The tests do run faster locally but still timeout in CI (I'm assuming the CI environment does not give a lot of compute cycles, relatively speaking...)

@ralexstokes ralexstokes transferred this issue from ethereum/trinity Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant