Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import contracts from smart-contract-sanctuary #1670

Open
kuzdogan opened this issue Sep 30, 2024 · 13 comments
Open

Import contracts from smart-contract-sanctuary #1670

kuzdogan opened this issue Sep 30, 2024 · 13 comments
Assignees
Labels
good first issue Issues to start contributing to the project if you're not familiar with the codebase

Comments

@kuzdogan
Copy link
Member

There's the smart-contract-sanctuary repo that is no longer maintained:

https://github.com/tintinweb/smart-contract-sanctuary

It contains flattened verified source codes for contracts on different chains.

We should be able to run a script over those contracts to import any missing ones in our repository.

@kuzdogan kuzdogan added the good first issue Issues to start contributing to the project if you're not familiar with the codebase label Sep 30, 2024
@mabsattar
Copy link

Hi @kuzdogan i'd like to tackle this.

@kuzdogan
Copy link
Member Author

kuzdogan commented Oct 8, 2024

Thanks @mabsattar ! I will be assigning this to you. Do you need more instructions or is it clear?

@kuzdogan kuzdogan moved this from Triage to Sprint - In Progress in Sourcify Public Oct 8, 2024
@mabsattar
Copy link

hey @kuzdogan thank you for assigning me, if I understand correctly this repo needs to be updated with new contracts, it used to automatically submit contracts to 4byte.directory but the functionality has stopped working. so we have to update with new contracts that have been deployed on diff chains?

@kuzdogan
Copy link
Member Author

No this is a repository of verified contracts and their source codes. The owner stopped updating the contracts there but that's irrelevant.

What we want to do is to go over all of the sources here, format them properly for Sourcify and submit them for verification to the Sourcify server (sourcify.dev). That way we can increase the number of verified contracts on Sourcify

@mabsattar
Copy link

@kuzdogan okay, thanks for the clarification, I'll start working on it.

@Chirag-S-Kotian
Copy link

i am interested in solving this can i start ??

@kuzdogan
Copy link
Member Author

@mabsattar could you share your progress on this?

@mabsattar
Copy link

hi @kuzdogan i'm working on it, couldn't work last week, I've run the script today and was able to find some contracts missing in the ETH mainnet, lemme validate, i'll keep you updated on this.

@kuzdogan
Copy link
Member Author

@mabsattar Thanks. In that case I'd keep it at @mabsattar to avoid conflicts and double-work @Chirag-S-Kotian

@Chirag-S-Kotian
Copy link

Okay if you have any other issues to solve please let me know 😊😁.

@manuelwedler
Copy link
Collaborator

@mabsattar any update on this?

@mabsattar
Copy link

@manuelwedler hi, I'll get it done soon, sorry was not available last couple of weeks. I've already created a script to find missing Contracts, extract data and format them for sourcify, i'll try to complete it and will update on this soon.

@manuelwedler
Copy link
Collaborator

@mabsattar Thanks for the update! Let us know when you are done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues to start contributing to the project if you're not familiar with the codebase
Projects
Status: Sprint - In Progress
Development

No branches or pull requests

4 participants