You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As an extension to this issue, it would ideally be better, if all the places in the code where the zip function is used be tested in some way (probably unittests).
What is wrong?
If I read the current implementation of
FQP.__eq__
correctly, it returnsTrue
for this test:which seems wrong.
In the current implementation,
zip
terminates on the shorter list, and there's no explicit length/degree check.How can it be fixed
Add tests for related scenarios, and make sure implementation is correct.
Also, because of the type checking involved, make sure that the equality test is commutative when the class is different, like:
The text was updated successfully, but these errors were encountered: