-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc-compat: Run speccheck
on non-deterministic tests
#640
Comments
I'm adding a |
This is a really nice idea, I am happy to begin using it. |
I'm working on it right now! |
Parsing of the flag is now implemented in the simulator, but it's unclear to me how to proceed with adding |
Some methods are not deterministic across clients. For example,
eth_gasPrice
returns asgasPrice
in wei that users could use for a transaction to be included quickly. This is subjective based on client so a static test case doesn't make sense. However, we know what the shape the request and response should look like. So it would make sense to make the request anyways and verify the round trip against the spec.I've written a tool
speccheck
which more-or-less does this. However it doesn't yet have the ability to verify round-trips that aren't written to file in the format of the test fixtures. So it would need to be librarified to a degree and then imported intorpc-compat
and run against certain non-deterministic endpoints (maybe even all of them!).The text was updated successfully, but these errors were encountered: