Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: TODO: symbolic abi encoding for bytes -- needs AbiBytesDynamicType Abi encoding in symAbiArg #533

Open
ethever opened this issue Aug 21, 2024 · 4 comments

Comments

@ethever
Copy link

ethever commented Aug 21, 2024

 hevm symbolic --rpc ***   --address 0x4593bc01601670d8f7141561bc25a28a931b0e2d  --show-reachable-tree --sig "swap(uint256,uint256,address,bytes calldata)" 

hevm: Internal Error: TODO: symbolic abi encoding for bytes -- CallStack (from HasCallStack):
  internalError, called at src/EVM/SymExec.hs:128:8 in hevm-0.53.0-d07512fec8d8a047a5494fc935ecbd7c50c0fcb527162bfecdae8ac151a019a8:EVM.SymExec
CallStack (from HasCallStack):
  error, called at src/EVM/Types.hs:1347:19 in hevm-0.53.0-d07512fec8d8a047a5494fc935ecbd7c50c0fcb527162bfecdae8ac151a019a8:EVM.Types
  internalError, called at src/EVM/SymExec.hs:128:8 in hevm-0.53.0-d07512fec8d8a047a5494fc935ecbd7c50c0fcb527162bfecdae8ac151a019a8:EVM.SymExec
@ethever
Copy link
Author

ethever commented Aug 21, 2024

Should we add bytes supportting as a AbstractBuf or ConcreteBuf?

@ethever ethever changed the title TODO: symbolic abi encoding for bytes error: TODO: symbolic abi encoding for bytes Aug 21, 2024
@msooseth
Copy link
Collaborator

So we have improved this part with #522 . If you could review that then we could merge and then we can maybe work on this. Otherwise, whatever we do here will conflict with that and it'll be a nightmare to do :)

@msooseth
Copy link
Collaborator

Ah, it's been merged! Well, then, we can work on this with a bit more confidence, as that thing has a fuzzer!

@msooseth msooseth changed the title error: TODO: symbolic abi encoding for bytes error: TODO: symbolic abi encoding for bytes -- needs AbiBytesDynamicType Abi encoding in symAbiArg Aug 21, 2024
@msooseth
Copy link
Collaborator

msooseth commented Dec 5, 2024

I just checked, it's still an issue. We can decode dynamic data, but setting it as a parameter as per swap(uint256,uint256,address,bytes calldata), where the bytes calldata is dynamic, is still not supported :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants