Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹chore(test): Deprecate version references from tests #963

Open
raxhvl opened this issue Nov 22, 2024 · 0 comments
Open

🧹chore(test): Deprecate version references from tests #963

raxhvl opened this issue Nov 22, 2024 · 0 comments

Comments

@raxhvl
Copy link
Contributor

raxhvl commented Nov 22, 2024

For now we can populate these expected global variables with dummy values to make allow fill to run on these tests. I don't think it's worth trying to retrieve the required hash from ethereum/EIPs from Github in make test as I think we should remove this feature from fill sooner rather than later. It's not maintained or actively used.

Originally posted by @danceratopz in #950 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant