Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmone-t8n reads currentDifficulty as hex field even if it is dec #1078

Open
winsvega opened this issue Dec 4, 2024 · 3 comments
Open

evmone-t8n reads currentDifficulty as hex field even if it is dec #1078

winsvega opened this issue Dec 4, 2024 · 3 comments
Assignees
Labels
tests Testing infrastructure

Comments

@winsvega
Copy link

winsvega commented Dec 4, 2024

Apparently evmone-t8n read currentDifficulty : "131072" as a hex value `0x131072" event though it should be "0x020000"
the field is only hex if it is prefixed by 0x otherwise it is dec.

yes there is no strict format on t8n env.json or result.json. it's an issue.

please check that other fields are parsed from json in t8n reader correctly (if no 0x prefix then the field is dec)

@chfast chfast added the tests Testing infrastructure label Dec 4, 2024
@chfast
Copy link
Member

chfast commented Dec 4, 2024

This is pretty fucked up that you put numeric values as strings...

@winsvega
Copy link
Author

winsvega commented Dec 4, 2024

well, I think I can enforce from pyspecs to always put 0x hex values in env.json or any t8n input configs

@chfast
Copy link
Member

chfast commented Dec 4, 2024

We can fix it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants