Implement last-call-deadline check for EIPs in Last Call status #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeaircreative
force-pushed
the
update-merge-functionality
branch
from
68760c9 to
5b89152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #21 by implementing a check to ensure the "last-call-deadline" for EIPs in "Last Call" status is at least two weeks in the future from the last commit date.
Changes Made
preMergeChangesfunction inmerge.tsto include the new checkErrors Encountered
I am new to open source contribution and encountered the following errors when running the tests locally:
Module Not Found Errors:
Cannot find module './types' or its corresponding type declarations.Cannot find module 'front-matter' or its corresponding type declarations.Cannot find module 'js-yaml' or its corresponding type declarations.Cannot find module '../src/merge' or its corresponding type declarations.Cannot find module '../src/types' or its corresponding type declarations.Incorrect Type Imports:
Module '\"@octokit/webhooks-types\"' has no exported member 'FrontMatter'.Module '\"@octokit/webhooks-types\"' has no exported member 'File'.Discussion from the Group
Based on the discussion, to use the eip-review-bot, you need to fork the ethereum/ERCs and/or ethereum/EIPs repositories. After forking, you'll need to configure the GitHub Actions workflow files and secrets in your forked repository to get the bot working.
The purpose of the eip-review-bot is to decide when to merge pull requests on the EIPs and ERCs repositories. It automatically merges an author's pull requests for their proposals without requiring an EIP Editor's involvement. When an Editor review is required, the bot pings the correct people in a comment.
Once the repository is forked and configured, the bot will run automatically after you create a pull request. You don't need to manually run it after creating a PR.
Request for Guidance
I'm new to contributing and would appreciate guidance on resolving the errors encountered and on the overall implementation. Thank you for your time and consideration!