Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editors shouldn't count as their own approval #139

Open
SamWilsn opened this issue Mar 9, 2023 · 5 comments
Open

Editors shouldn't count as their own approval #139

SamWilsn opened this issue Mar 9, 2023 · 5 comments
Labels
🐛 bug Something isn't working 🗨️ in discussion

Comments

@SamWilsn
Copy link
Contributor

SamWilsn commented Mar 9, 2023

For example, @lightclient is both an author and an editor: ethereum/EIPs#6642
@Pandapip1
Copy link
Member

Pandapip1 commented Mar 14, 2023 •
edited
Loading

I made it so that it double counts for the special case of moving from Stagnant. LMK if that seems unreasonable.

@Pandapip1 Pandapip1 added 🐛 bug Something isn't working 🗨️ in discussion labels Mar 22, 2023
@SamWilsn
Copy link
Contributor Author

Can we make it so editors don't count as editors for proposals they're authoring in any case? I think that's the most consistent, if more annoying.

@Pandapip1
Copy link
Member

Pandapip1 commented Mar 22, 2023 •
edited
Loading

Can we make it so editors don't count as editors for proposals they're authoring in any case? I think that's the most consistent, if more annoying.

They don't, or at least, they shouldn't. Is there a case you can point to where this happened?

@SamWilsn
Copy link
Contributor Author

I thought "double counts" in your comment meant counting as an editor and as an author in the special case of moving out of stagnant.

@Pandapip1
Copy link
Member

It does mean that. I thought your comment meant other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🗨️ in discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pandapip1 @SamWilsn