Bump GOSSIP_MAX_SIZE from 10MiB to 15MiB #4041
Conversation
|
this text also needs to be updated or removed from https://github.com/ethereum/consensus-specs/blob/dev/specs/bellatrix/p2p-interface.md? with the addition of ExecutionPayload to BeaconBlocks, there is a dynamic field -- transactions -- which can validly exceed the GOSSIP_MAX_SIZE limit (1 MiB) put in place at Phase 0, so GOSSIP_MAX_SIZE has increased to 10 Mib on the network. At the GAS_LIMIT (~30M) currently seen on mainnet in 2021, a single transaction filled entirely with data at a c |
|
@g11tech is it better now? |
|
A PR description here with some math behind this specific number would be helpful here, along with some reasoning about how this is going to affect distribution times, latency, overall bandwidth given gossip amplification factors etc. |
|
Also, notably, changes like this should happen at a hard fork, else we risk creating a split network based off nodes that have and have not upgraded (and would therefore penalise the upgraded nodes that are sending "too large" messages - in the worst case of half the validators having upgraded, this would lead to non-finality effectively) - the way we've dealt with this in the past is to have a separate constant for the "next" hard fork that will use the new limit for messages in the new hard fork. Finally, req/resp is governed by similar rules - we upgrade the two constants together. |
I think it is the same constant - also as you know we are already exchanging messages on a private channel about this issue. please keep the conversation there. |
|
done |
Do we already have an EIP to increase the gas limit from 30mn to 60mn? If not, changing this before the gas limit seems weird. |
You change this first so that everything does not break :D. not the other way around |
|
@Giulio2002 can you provide some calculation that it can really exceed 10MiB? We have an EIP that is trying to reduce the block size https://eips.ethereum.org/EIPS/eip-7623 which is opposite to this PR. Could you please elaborate more? The current spec also says that with calldata gas of 16 and gas limit 30M, the max block size is actually 2MiB which is already lower than 10Mib. |
Yeah, the spec is wrong. it is not safe to increase the gas limit to >38 million because of this. 15 MiB is okay and was discussed with all other CL clients |
|
also just for reference - prysm merged their PR with the change: prysmaticlabs/prysm#14692 |
|
@Giulio2002 The max gossip size in prysm is still |
GOSSIP_MAX_SIZE is on the fence for worst case block and it will be especially if we consider an increase in gas limit which seems to be strongly pushed by the community. 15 MiB gives large space for an increase up 60mn gas.