Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error when adding a frontier chain with no deploy-config #601

Open
geoknee opened this issue Sep 17, 2024 · 0 comments
Open

Handle error when adding a frontier chain with no deploy-config #601

geoknee opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@geoknee
Copy link
Collaborator

geoknee commented Sep 17, 2024

We should modify this code:

err = copyDeployConfigFile(deployConfigPath, genesisValidationInputsDir)
if err != nil {
return fmt.Errorf("error copying deploy-config json file: %w", err)
}
fmt.Printf("✅ Copied deploy-config json file to validation module\n")

so that if the chain is frontier and not a standard candidate, we swallow the error and print out a meaningful message since we do not require this information for chains that won't ever be subject to the genesis-allocs validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants