Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open screenshots in app #28

Open
tkaragianes opened this issue Feb 23, 2022 · 2 comments
Open

Open screenshots in app #28

tkaragianes opened this issue Feb 23, 2022 · 2 comments
Labels
rewrite fix An issue that will be addressed in the refactor type: enhancement New feature or request

Comments

@tkaragianes
Copy link
Contributor

"Clicking an Eterna screenshot in chat takes me to an outside browser (in my case, Chrome) - would be cool if I could view it from within the app"

I have a feeling that this is related to Cordova. Not sure if we want to address it now or with the refactor.

@tkaragianes tkaragianes added the type: enhancement New feature or request label Feb 23, 2022
@tkaragianes tkaragianes added the rewrite fix An issue that will be addressed in the refactor label Mar 3, 2022
@tkaragianes
Copy link
Contributor Author

This behavior is the same as currently implemented in the site (e.g., screenshots open in a new tab, not in app). There are ways to solve this now (cordova inappbrowser plugin), but my recommendation is to push this improvement as part of the refactor so we can implement it correctly in both the mobile app and website.

@luxaritas
Copy link
Member

luxaritas commented Mar 3, 2022

The Vue chat rewrite actually embeds image links (or at least screenshots), so that's probably the real resolution of this specific issue - though we may still want chat links in general to open with an in-app browser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rewrite fix An issue that will be addressed in the refactor type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants