Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out most usage of VueX #139

Open
luxaritas opened this issue Sep 24, 2024 · 0 comments
Open

Rip out most usage of VueX #139

luxaritas opened this issue Sep 24, 2024 · 0 comments
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact size: md type: ergonomics Tooling, refactoring, etc

Comments

@luxaritas
Copy link
Member

Right now, we use VueX in way more situations than we should. There's this common pattern of delegating a network request to VueX and it stores the response on the state, however in many cases there's no reason why it needs to be in a central state store instead of handling the fetch and response inline (even if we need to access it in a different component, often times its better to just pass the data as a prop), plus it creates room for bugs where old invalid data gets used because it's really tied to the page but is cached across pages (see #138 for an example).

@luxaritas luxaritas added type: ergonomics Tooling, refactoring, etc priority: p3/standard Enhancement with nominal value or bug with nominal impact size: md labels Sep 24, 2024
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact size: md type: ergonomics Tooling, refactoring, etc
Projects
Status: Todo
Development

No branches or pull requests

1 participant