Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add device authentication to app lock flow #952

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

rhbrunetto
Copy link
Contributor

@rhbrunetto rhbrunetto commented Apr 28, 2023

Changes

  • Allows user to authenticate using the method enrolled on device (biometrics, pin, pattern) when app is locked.
Demo
mia3.mov

Related issues

Fixes #601

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #952 (cc08494) into master (dc928f6) will not change coverage.
The diff coverage is n/a.

❗ Current head cc08494 differs from pull request most recent head bc6cd35. Consider uploading reports for the commit bc6cd35 to get more accurate results

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files         183      183           
  Lines        3942     3942           
=======================================
  Hits         3199     3199           
  Misses        743      743           
Flag Coverage Δ
solana-beta 81.15% <ø> (?)
solana-stable 81.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rhbrunetto
Copy link
Contributor Author

Added demo @antoineherzog

@rhbrunetto rhbrunetto marked this pull request as draft May 2, 2023 14:25
@rhbrunetto rhbrunetto marked this pull request as ready for review May 2, 2023 18:16
@rhbrunetto
Copy link
Contributor Author

@antoineherzog updated demo. Recording has a low fps due to streaming from real device over wifi.

Copy link
Collaborator

@ookami-kb ookami-kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin code should always be enabled and used as a fallback to the biometrics authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve app lock
2 participants