Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show incoming link amount #1199

Closed
wants to merge 14 commits into from
Closed

feat: show incoming link amount #1199

wants to merge 14 commits into from

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented Jan 2, 2024 •
edited
Loading

Changes

adds received amount for incoming link

Related issues

Fixes #1175

Video

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-02.at.10.48.26.mp4

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (43de4a7) to head (19f09ef).
Report is 272 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files         185      185           
  Lines        4075     4075           
=======================================
  Hits         3228     3228           
  Misses        847      847
Flag Coverage Δ
solana-beta 79.21% <ø> (?)
solana-stable 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@justinenerio justinenerio marked this pull request as ready for review January 2, 2024 03:06
ookami-kb
ookami-kb requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@ookami-kb ookami-kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can get this information, let's not store it in DB.

Also, is there a way to get it from the tx itself without requesting parsed tx details from the node?

@justinenerio
Copy link
Contributor Author

@ookami-kb I think its not possible to get the amount from tx itself since its done in anchor contract. the amount isn’t exposed in the input or output of the instruction

@justinenerio
Copy link
Contributor Author

replaced by: #1610

@justinenerio justinenerio deleted the incoming-link-amount branch November 19, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb Awaiting requested review from ookami-kb ookami-kb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make sure to display the amount that has been received
2 participants
@justinenerio @ookami-kb