Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Test Coverage #685

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Add unit tests for Test Coverage #685

wants to merge 38 commits into from
+120 −9

Conversation

radurentea
Copy link
Collaborator

No description provided.

@radurentea radurentea changed the title Add gcov example in testfiles folder; Testing on CI Add unit tests for Test Coverage May 10, 2022
@radurentea radurentea marked this pull request as ready for review May 10, 2022 08:14
@github-actions
Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label May 26, 2022
@brianignacio5
Copy link
Collaborator

Could you simplify the required files for these testing ?

gcovr only needs the .gcda and .gcno files in the project. So having the .c files should be enough to run gcovr and get the output.

You could test the html against a given expected output in buildHtml function. The generateCoverageForEditors function should also be more descriptive,

@github-actions github-actions bot removed the stale Stale PR or Issue label May 27, 2022
@github-actions
Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jun 25, 2022
@github-actions github-actions bot closed this Jul 1, 2022
@radurentea radurentea reopened this Jul 25, 2022
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Jul 25, 2022
@radurentea
Removing workspaceFolder
bcdf476
@radurentea
Revert "Removing workspaceFolder"
fb3a3e9 
This reverts commit ea8a170.
@radurentea
Update testCoverage.test.ts
21352e4
@radurentea
Update c_cpp_properties.json
9af4652
@radurentea
Revert "Update c_cpp_properties.json"
2e867f6 
This reverts commit ebaf72d.
@radurentea
Removing .dovcontainer
93158a3
@radurentea
Revert "Removing .dovcontainer"
7ae6380 
This reverts commit 2bda086.
@radurentea
Replace config variables with env variables
94dda21
@radurentea
Revert "Replace config variables with env variables"
190b511 
This reverts commit 1cee854.
@radurentea
Testing if the test results are changing on CI
7a8e562
@radurentea
Revert "Testing if the test results are changing on CI"
e0ff6bf 
This reverts commit 5b2a11d.
@radurentea
Testing on CI - removing paths from settings.json
d3648d9
@radurentea
Replacing example folders
614d62e 
Replacing "main" and "components" folders with fresh ones from a gcov example.
@radurentea
Testing on CI - removing mockup_files folder
a03023a
@radurentea
Fix unit test for buildJson function
68d13d8
@radurentea
Add unit test for buildHtml function
ad60a4f
@radurentea
Fix test unit for buildHtml function; Add comments for some test cove…
a62a3fb 
…rage unit tests;
@radurentea
Add test unit for generateCoverageForEditors()
6323c4c
@radurentea
Remove unnecessary files; Add description;
51b36a3
@radurentea
Add gcda and gcno mockup files
f9a5343
@radurentea
Revert "Add gcda and gcno mockup files"
fa60585 
This reverts commit 2309239.
brianignacio5
brianignacio5 requested changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test("generateCoverageForEditors") is not testing anything.

Should open one of the test project files and test that result array contain an editor with same filePath as one of the file from the test project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 requested changes

Assignees
No one assigned
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radurentea @brianignacio5