Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Provide CN translation for settings.rst #1341

Merged
merged 1 commit into from
Nov 29, 2024
Merged

docs: Provide CN translation for settings.rst #1341

merged 1 commit into from
Nov 29, 2024

Conversation

Shen765
Copy link
Collaborator

@Shen765 Shen765 commented Nov 13, 2024

Description

This PR:

  • Adjusted some format issues and unclear expressions in settings.rst based on Espressif Style Guide
  • Provided CN translation for settings.rst
  • TODO: Closes DOC-9380 once merged

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Shen765 Shen765 force-pushed the docs/translate_settings branch 4 times, most recently from 3174d75 to 3674c3e Compare November 14, 2024 09:14
@Shen765 Shen765 self-assigned this Nov 14, 2024
@Shen765 Shen765 added the documentation 📝 Solely about the documentation of the project. label Nov 14, 2024
0cici
0cici reviewed Nov 15, 2024
View reviewed changes
docs_espressif/zh_CN/settings.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/settings.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/settings.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/settings.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/settings.rst Outdated Show resolved Hide resolved
docs_espressif/en/settings.rst Outdated Show resolved Hide resolved
docs_espressif/en/settings.rst Outdated Show resolved Hide resolved
docs_espressif/en/settings.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/settings.rst Outdated Show resolved Hide resolved
@0cici
Copy link

0cici commented Nov 15, 2024

Hi @Shen765 , thanks for translating the file! Left a few suggestions, please take a look~

brianignacio5
brianignacio5 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shen765 Shen765 force-pushed the docs/translate_settings branch 5 times, most recently from 1a65286 to 98fbbad Compare November 29, 2024 07:30
@Shen765 Shen765 merged commit 0911e67 into master Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zztiger123 zztiger123 zztiger123 approved these changes

@0cici 0cici 0cici approved these changes

@brianignacio5 brianignacio5 brianignacio5 approved these changes

Assignees

@Shen765 Shen765

Labels
documentation 📝 Solely about the documentation of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shen765 @0cici @brianignacio5 @zztiger123