return in finally swallows exceptions (ESPTOOL-948)

[iritkatriel]

Operating System

NA

Esptool Version

master branch

Python Version

NA

Full Esptool Command Line that Was Run

NA

Esptool Output

NA

What is the Expected Behaviour?

Avoid return in finally.

More Information

In

esptool/esptool/cmds.py

Line 158 in 8298cdc

return inst

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

Other Steps to Reproduce

No response

[Honza0297]

Hello @iritkatriel and thank you for reporting this!
We will look into this and fix it.