Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc-ncm ethernet speed hardcoded (IEC-175) #69

Open
2 tasks done
chegewara opened this issue Oct 1, 2024 · 2 comments
Open
2 tasks done

cdc-ncm ethernet speed hardcoded (IEC-175) #69

chegewara opened this issue Oct 1, 2024 · 2 comments

Comments

@chegewara
Copy link

Answers checklist.

  • I have read the documentation of the component in question and the issue is not addressed there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

Hi,
since we are having now P4 with USB-HS, is it possible to update ethernet speed notification code according to upstream repo?

hathach/tinyusb#742

tu_static struct ncm_notify_t ncm_notify_speed_change = {
    .header = {
        .bmRequestType_bit = {
            .recipient = TUSB_REQ_RCPT_INTERFACE,
            .type = TUSB_REQ_TYPE_CLASS,
            .direction = TUSB_DIR_IN},
        .bRequest = CDC_NOTIF_CONNECTION_SPEED_CHANGE,
        .wLength = 8,
    },
    .downlink = TUD_OPT_HIGH_SPEED ? 480000000 : 12000000,
    .uplink = TUD_OPT_HIGH_SPEED ? 480000000 : 12000000,
};

Now we are having hardcoded ethernet speed 10mb/s

Thanks

@github-actions github-actions bot changed the title cdc-ncm ethernet speed hardcoded cdc-ncm ethernet speed hardcoded (IEC-175) Oct 1, 2024
@tore-espressif
Copy link
Collaborator

Yes, this is definitely on our todo list. Internally, we made only few P4+USB+network tests, but did not manage to make it public yet.

We will update this ticket when we have some news to share

@chegewara
Copy link
Author

Thanks
It is not that important thou.
From my test I can tell it's just cosmetic value to display in OS, it doesn't impact on real transfer speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants