Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example i2c_master_slave.rs uses GPIO22 which doesn't exist on esp32s3 #329

Closed
maayanhaimdulberg opened this issue Oct 24, 2023 · 2 comments
Closed

example i2c_master_slave.rs uses GPIO22 which doesn't exist on esp32s3 #329

maayanhaimdulberg opened this issue Oct 24, 2023 · 2 comments

Comments

@maayanhaimdulberg
Copy link

maayanhaimdulberg commented Oct 24, 2023 •
edited
Loading

Hi all

The example i2c_master_slave.rs uses GPIO22 for I2C
image

The thing is, the famous ESP-32-S3-DevKitC-1 and esp32s3 in general, do not have a GPIO22.
Maybe it is best to change the pins in the example, to suit any kind of esp32?

esp32s3 page 460
image

esp32 page 48
image
@maayanhaimdulberg maayanhaimdulberg changed the title example i2c_master_slave.rs example i2c_master_slave.rs uses GPIO22 which doesn't exist on esp32s3 Oct 24, 2023
@ivmarkov
Copy link
Collaborator

PRs welcome!

@mdolberg mdolberg mentioned this issue Oct 25, 2023
Closed
@mdolberg
Copy link

Challenge accepted. Hope I did it right. First PR in an open source project ever.
#330

@ivmarkov ivmarkov closed this as completed Nov 7, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivmarkov @mdolberg @maayanhaimdulberg