-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ListFolders: folders with invalid name should just be dropped, not cause a fatal error #322
Comments
Hmm, this has other implications. The last version added support for nested folders which has become a standard feature available in grafana now. So Ignoring the folder also affects all potential dashboards within that folder. It also impacts the dashboards. The issue with the 'warning', is that there's folks that run GDG in a crontab or as kubenetes job, in which case nobody is really actively reading the logs as it's just expected to work. When an operation is potentially dropping an entire folder and all its content from being backed up. I think the fatal error is correct. We could potentially introduce a configuration option to allow this but I definitely don't think it should be the default behavior. The special chars that are checked for intentionally because they have an impact on other features of GDG besides just the folder names. |
Fixes #322 ChangeLog: - Introducing an ignore bad folders options - Adding invalid folder to test data TechDebt: - bumping golang version to 1.23.4 - Refacotring App initialization to make testing a bit easier - Refactoring moving Storage functionality into its own package
Fixes #322 ChangeLog: - Introducing an ignore bad folders options - Adding invalid folder to test data TechDebt: - bumping golang version to 1.23.4 - Refacotring App initialization to make testing a bit easier - Refactoring moving Storage functionality into its own package
Fixes #322 ChangeLog: - Introducing an ignore bad folders options - Adding invalid folder to test data TechDebt: - bumping golang version to 1.23.4 - Refacotring App initialization to make testing a bit easier - Refactoring moving Storage functionality into its own package
Fixes #322 ChangeLog: - Introducing an ignore bad folders options - Adding invalid folder to test data TechDebt: - bumping golang version to 1.23.4 - Refacotring App initialization to make testing a bit easier - Refactoring moving Storage functionality into its own package
Fixes #322 ChangeLog: - Introducing an ignore bad folders options - Adding invalid folder to test data TechDebt: - bumping golang version to 1.23.4 - Refacotring App initialization to make testing a bit easier - Refactoring moving Storage functionality into its own package
PR: #324 |
Is your feature request related to a problem? Please describe.
Feature. Invalid folders shouldn't be a fatal error, they should just be ignored.
Describe the solution you'd like
Invalid folders are ignored, and the program can continue.
Describe alternatives you've considered
I could have nagged the folder owner to change the folder's title.
Additional context
This diff allowed me to backup a valid folder (despite the invalid folder existing).
The text was updated successfully, but these errors were encountered: