Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup.py): pin all dependencies to a specific number #740

Merged
merged 12 commits into from
Aug 21, 2023

Conversation

pgierz
Copy link
Member

@pgierz pgierz commented Jul 13, 2022

Closes #694

Why did I do this? Because non-specific version numbers are a disaster waiting to happen. See dask/dask-gateway#565

@pgierz pgierz marked this pull request as draft July 13, 2022 14:25
@pgierz pgierz requested a review from mandresm July 13, 2022 14:44
@pgierz pgierz marked this pull request as ready for review July 13, 2022 14:44
@pgierz
Copy link
Member Author

pgierz commented Jul 13, 2022

Remaining failing tests are from an old version of the "Truth" (tm)

@pgierz pgierz added the dependencies Pull requests that update a dependency file label Aug 1, 2022
Copy link
Contributor

@mandresm mandresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this branch with release but something on the dependencies side broke the tests.

@nwieters nwieters mentioned this pull request Aug 21, 2023
@pgierz pgierz merged commit 9b04d2b into release Aug 21, 2023
@mandresm mandresm deleted the fix/pinned_version branch August 28, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure version pins
2 participants