Sprint/workflow_manager #1041
Draft
Sprint/workflow_manager #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwieters
added
enhancement
mandresm
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Great job so far @nwieters! I'm half way through the review, I'll continue tomorrow. It's way more clear, however, I don't yet understand the whole architecture of the new code, but so far it makes sense to me. Maybe we need to consider changing some of the methods below to be moved into the Workflow class, but that's a discussion for later.
mandresm
reviewed
Oct 16, 2023
Co-authored-by: Miguel <[email protected]>
Co-authored-by: Miguel <[email protected]>
Co-authored-by: Miguel <[email protected]>
|
I hope that these were the last conceptual changes to the code. I will now start to do a cleanup and do some code optimizations. To run only the tests for examples, run |
…after/run_before.
…entation Sprint/workflow manager documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring workflow manager
Can be tested by calling
esm_runscripts <runscript.yaml> -i workflowExamples:
https://esm-tools.readthedocs.io/en/sprint-workflow_manager_documentation/workflow.html#examples-for-the-definition-of-new-workflow-phases
Closes #1047