Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with https://github.com/ianbollinger/purescript-web-storage #11

Open
eskimor opened this issue Aug 11, 2016 · 4 comments
Open

Merge with https://github.com/ianbollinger/purescript-web-storage #11

eskimor opened this issue Aug 11, 2016 · 4 comments

Comments

@eskimor
Copy link
Owner

eskimor commented Aug 11, 2016

Now that we have at least two libraries offering the same functionality. We probably should either merge them or base one on top of the other.

@eskimor
Copy link
Owner Author

eskimor commented Aug 11, 2016

I won't be able to tackle this soon, as I should really focus on my own project right now - so any help on this would be appreciated!

@texastoland
Copy link
Contributor

texastoland commented Aug 13, 2016

I should be able to within a week! I think it's a breaking change because of @ianbollinger's point about needing EXCEPTION. I could use help figuring out whether the spec is outdated regarding localstorage raising a SecurityError.

@ianbollinger
Copy link

It does appear to throw a SecurityError on some browsers; others just set it to null. https://bugs.chromium.org/p/chromium/issues/detail?id=357625

@texastoland
Copy link
Contributor

Thanks @ianbollinger expect a PR this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants