Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is-builtin-module from rollup #49

Closed
43081j opened this issue May 13, 2024 · 2 comments
Closed

Remove is-builtin-module from rollup #49

43081j opened this issue May 13, 2024 · 2 comments

Comments

@43081j
Copy link
Collaborator

43081j commented May 13, 2024

rollup uses is-builtin-module here:
https://github.com/rollup/plugins/blob/9e7f576f33e26d65e9f2221d248a2e000923e03f/packages/node-resolve/src/index.js#L193

it has an engine constraint of >=14 which means we can't use isBuiltin from node itself.

however, we can use builtinModules with a simple string replace:

import {builtinModules} from 'node:module';

const name = '...';
builtinModules.includes(name.replace('node:', ''));
@43081j
Copy link
Collaborator Author

43081j commented Jun 7, 2024

tracked in rollup/plugins#1735

@MichaelDeBoey
Copy link

rollup/plugins#1735 is now merged

@43081j 43081j closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants