Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-bindgen feature #37

Closed
astrale-sharp opened this issue Aug 29, 2023 · 5 comments · Fixed by #38
Closed

wasm-bindgen feature #37

astrale-sharp opened this issue Aug 29, 2023 · 5 comments · Fixed by #38

Comments

@astrale-sharp
Copy link

For use via wasmi, wasm-bindgen is a problem, would you consider putting it behind a feature? If it's straightforward I could probably even find time to create a PR if you're interested, I have a temporary fix in my fork here

@astrale-sharp
Copy link
Author

really nice project btw :3

@erwanvivien
Copy link
Owner

Hey 👋 Could you explain more about why wasm-bindgen is a problem, I'm not aware of the issue!

@astrale-sharp
Copy link
Author

rustwasm/wasm-bindgen#3421

In my limited understanding, wasm-bindgen is made for the web, as such it requires webassembly functions available only through the browser.

But the work here https://github.com/EpicEricEE/typst-plugins is made to bundle fast_qr as a plugin for typst, hence we don't have browser capabilities.

@erwanvivien
Copy link
Owner

Alright then 👍

Do you want to PR the branch in EpicEricEE?

@astrale-sharp
Copy link
Author

Apparently they're on it so absolutly, i guess !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants